-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vstreamer to throttle on source endpoint #7324
vstreamer to throttle on source endpoint #7324
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
…amer pulling data from source Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…le() function Signed-off-by: Shlomi Noach <[email protected]>
…rapping events channel with throttledEvents, which only pulls data from events if not throttled Signed-off-by: Shlomi Noach <[email protected]>
@rohit-nayak-ps please see my recent changes. On Otherwise, added throttling in rowstreamer and resultstreamer. |
Next up, I'l create an |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…e-source-check-self Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
… keyword Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
I've moved |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…e-source-check-self Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
The new workflow yaml file for the e2e test should be created by updating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
test script / e2e workflow yaml needs to be updated as per comment.
Oh, I completely missed this! |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
because this PR introduced a named endtoend shard ( |
Description
VReplication works by hooking to a
source
tablet, pulling data as a replica as well as scanning tables, then to be applied on atarget
tablet.On
source
, VReplication (viavstreamer
) can cause a high load by aggressively pulling data, such that:source
is a replica, it can start laggingsource
is a primary, it becomes sluggishWith this PR,
vstreamer
throttles based oncheck-self
, introduced in #7319 , which is a throttle endpoint that tests the health of a specific tablet, thesource
tablet in our scenario. Right now, as described in #7319, whether replica or primary, we test for replication lag, which is an actual indicator on primary, too.Related Issue(s)
Tracking issue: #7362
This PR extends and depends on #7319
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: