Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request template: link to contribution guide #7314

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Pull Request template: link to contribution guide #7314

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
621e835
Pull Request template: link to contribution guide
shlomi-noach Jan 18, 2021
32fec17
better instructions on pull request template
shlomi-noach Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
<!--
How to contribute: https://vitess.io/docs/contributing/
We’re looking forward to any contribution! Before you start larger contributions, make sure to reach out first and discuss your plans with us.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

us should link somewhere useful. (I know the doc on the website has the same language and the same problem).
How about linking it to the #developers slack channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that "us" is vague. This line was copied from https://vitess.io/docs/contributing/ by way of TL;DR. I'm not sure we want to ask people to discuss all contributions on #developers . We should rather encourage them to open an issue. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Let us ask them to create an issue to document the feature, and if they have a proposal it can be marked as an RFC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

-->

<!-- if this PR is Work in Progress please create it as a Draft Pull Request -->

## Description
Expand Down