Addition of @@enable_system_settings to vtgate #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
|
The new variable is not tested for all test cases yet. Specifically the following one: vitess/go/vt/vtgate/executor_select_test.go Line 319 in 0fa0fc7 This specific test case relates to the issue mentioned in #7301. |
frouioui
requested review from
harshit-gangal,
sougou and
systay
as code owners
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Updated test
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
changed the title
systay
reviewed
Jan 19, 2021
|
It would be great if you could add an end to end test in https://github.com/vitessio/vitess/blob/master/go/test/endtoend/vtgate/reservedconn/sysvar_test.go |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
systay
approved these changes
Jan 20, 2021
|
Really nice. Welcome as new contributor! 🤗 |
|
Awesome! Thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florent Poinsard [email protected]
Description
This pull request introduces a new system variable:
enable_system_settings. ThisVitessAwarevariable is used to define wether the current session is allowed to use reserved connection or not.The default value of the variable is based on VTGate's
-enable_system_settingsflag.Fixes #6860.
Checklist
Impacted Areas in Vitess
Components that this PR will affect: