Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/vttestserver: Add MYSQL_BIND_HOST env #7293

Merged

Conversation

mcronce
Copy link

@mcronce mcronce commented Jan 13, 2021

Description

Adds an optional MYSQL_BIND_HOST environment variable to the vttestserver container; if included, this is passed as -mysql_bind_host to vttestserver

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Run as follows:

$ docker run --rm -d -p33577:33577 -e PORT=33574 -e KEYSPACES=test -e NUM_SHARDS=1 -e MYSQL_BIND_HOST=0.0.0.0 vitess/vttestserver:mysql57
2c04c50156bd9ad7cac4b3f41bb653de37b78a0505c4154f1491e8d2730f5336
$ mysql -h127.0.0.1 -p33577
Welcome to the MySQL monitor.  Commands end with ; or \g.
Your MySQL connection id is 1
Server version: 5.7.9-Vitess MySQL Community Server (GPL)

Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved.

Oracle is a registered trademark of Oracle Corporation and/or its
affiliates. Other names may be trademarks of their respective
owners.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

mysql> SHOW DATABASES;
+----------+
| Database |
+----------+
| test     |
+----------+
1 row in set (0.00 sec)

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but DCO needs to be fixed before we can merge.

@mcronce mcronce force-pushed the vttestserver-container-listen-port branch from 5a8c1f4 to 96e9fb3 Compare January 14, 2021 02:49
@mcronce
Copy link
Author

mcronce commented Jan 14, 2021

@deepthi should be all set, thanks!

@deepthi deepthi merged commit a26cc27 into vitessio:master Jan 14, 2021
@deepthi deepthi deleted the vttestserver-container-listen-port branch January 14, 2021 19:03
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants