fix hang when local topo was down #7278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inolddays
force-pushed
the
fixlocaltopobrokeshowdatabasehang
branch
from
1fde084 to
32c8a64
Compare
deepthi
reviewed
Jan 19, 2021
go/vt/srvtopo/resilient_server.go
Outdated
| @@ -308,7 +310,8 @@ func (server *ResilientServer) GetSrvKeyspaceNames(ctx context.Context, cell str | |||
| server.counts.Add(errorCategory, 1) | |||
| if entry.insertionTime.IsZero() { | |||
| log.Errorf("GetSrvKeyspaceNames(%v, %v) failed: %v (no cached value, caching and returning error)", ctx, cell, err) | |||
|
|
|||
| } else if strings.Contains(err.Error(), "deadline exceeded") { | |||
There was a problem hiding this comment.
It will be better to check
newCtx.Err() == context.DeadlineExceeded
instead of checking for the error string.
Signed-off-by: JohnnyThree <[email protected]>
inolddays
force-pushed
the
fixlocaltopobrokeshowdatabasehang
branch
from
32c8a64 to
ebd8c60
Compare
This was referenced Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when local cell topo server is down, all commands related with function GetSrvKeyspaceNames are hanging
Added topo timeout and when local cell topo is broken , will use cache instead , make sure not too much effect on vtgate
Signed-off-by: JohnnyThree [email protected]
Description
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: