Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication DryRun: Report current dry run results for v2 commands #7255

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jan 5, 2021

Signed-off-by: Rohit Nayak [email protected]

Description

  • Implemented -dry_run flag for v2 commands
  • Essentially the same dry run logs from v1 commands are reported with minor changes

Related Issue(s)

#7071

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review January 5, 2021 23:03
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but we should wait for @sougou's review

go/test/endtoend/vreplication/vreplication_test_env.go Outdated Show resolved Hide resolved
go/test/endtoend/vreplication/vreplication_test_env.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor helptext change, otherwise lg2m

@@ -1968,7 +1968,7 @@ func commandVRWorkflow(ctx context.Context, wr *wrangler.Wrangler, subFlags *fla
workflowType wrangler.VReplicationWorkflowType) error {

cells := subFlags.String("cells", "", "Cell(s) or CellAlias(es) (comma-separated) to replicate from.")
tabletTypes := subFlags.String("tablet_types", "", "Source tablet types to replicate from (e.g. master, replica, rdonly). Defaults to -vreplication_tablet_type parameter value for the tablet, which has the default value of replica.")
tabletTypes := subFlags.String("tablet_types", "master,replica,rdonly", "Source tablet types to replicate from (e.g. master, replica, rdonly). Defaults to -vreplication_tablet_type parameter value for the tablet, which has the default value of replica.")
dryRun := subFlags.Bool("dry_run", false, "Does a dry run of SwitchReads and only reports the actions to be taken")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help should be updated to reflect line 2146

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks for pointing out!

Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps merged commit ba3fc66 into vitessio:master Jan 19, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-v2-dry-run branch January 19, 2021 16:41
rohit-nayak-ps added a commit that referenced this pull request Jan 22, 2021
Backport #7255: VReplication DryRun: Report current dry run results for v2 commands
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants