Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoveTables: delete routing rules and update vschema on Complete and Abort #7234

Merged
merged 4 commits into from
Jan 5, 2021
Merged

MoveTables: delete routing rules and update vschema on Complete and Abort #7234

merged 4 commits into from
Jan 5, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jan 1, 2021 •
edited
Loading

Description

  • Delete routing rules when a MoveTables workflow is marked as completed or aborted
  • Update source/target vschema to reflect the new tables when a MoveTables workflow is completed/aborted

Related Issue(s)

#7217

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Jan 1, 2021
Merged
@rohit-nayak-ps rohit-nayak-ps force-pushed the rn-wf-complete-drop-rr-update-vschema branch from ed1d95f to 6f9acd3 Compare January 3, 2021 11:08
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review January 4, 2021 08:48
@rohit-nayak-ps rohit-nayak-ps linked an issue Jan 4, 2021 that may be closed by this pull request
VSchema not updated after MoveTable. #7217
Closed
@rohit-nayak-ps rohit-nayak-ps merged commit 5b6dfb7 into vitessio:master Jan 5, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-wf-complete-drop-rr-update-vschema branch January 5, 2021 09:21
@askdba askdba added this to the v9.0 milestone Jan 6, 2021
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

VSchema not updated after MoveTable.
3 participants
@rohit-nayak-ps @sougou @askdba