Add @ajm188 + @doeg to CODEOWNERS for vtctld service files #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <[email protected]>
ajm188
approved these changes
Dec 18, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee [email protected]
Backport
NO
Status
READY
Description
Over the next few weeks, @ajm188 and I will be working through the vtctld service tickets. Concretely, we'll be posting PRs just like #7201 for each of the commands we're migrating.
To be super up front about the risk: our PRs will be updating
go/vt/vtctl/vtctl.go, which could affect downstream Vitess deployments. Hence we're being extra careful about backwards compatibility. Our timeline and rollout for this work is described in detail in the RFC: #7058.Related Issue(s)
List related PRs against other branches:
Todos
Deployment Notes
N/A
Impacted Areas in Vitess
List general components of the application that this PR will affect: