Allow system table to be set as default database #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…f empty Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Dec 10, 2020
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Dec 10, 2020
| require.NoError(err, "test expectation does not parse [%s]", tc.expected) | ||
|
|
||
| s := String(expected) | ||
| assert := assert.New(t) |
There was a problem hiding this comment.
nit: meh... if you are using a single assertion, not much use creating this struct, is there?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshit Gangal [email protected]
Backport
NO
Status
READY
Description
This PR allows setting system schema as default database name on connect or with
usestatement.Related Issue(s)
List related PRs against other branches:
Fixes #7146
Impacted Areas in Vitess
List general components of the application that this PR will affect: