Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] VDiff/Tablet Picker: fix picker retry logic to handle canceled context #6954

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[8.0] VDiff/Tablet Picker: fix picker retry logic to handle canceled context #6954

merged 1 commit into from
Oct 27, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Oct 27, 2020 •
edited by deepthi
Loading

Backport #6944

Signed-off-by: Rohit Nayak [email protected]

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review October 27, 2020 08:10
@rohit-nayak-ps rohit-nayak-ps requested a review from a team October 27, 2020 08:11
askdba
askdba approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already approved and merged in master and tests are passing.

@rohit-nayak-ps rohit-nayak-ps merged commit 060b3a4 into vitessio:release-8.0 Oct 27, 2020
@askdba askdba added this to the v8.0 milestone Oct 27, 2020
@deepthi deepthi changed the title VDiff/Tablet Picker: fix picker retry logic to handle canceled context [8.0] VDiff/Tablet Picker: fix picker retry logic to handle canceled context Oct 29, 2020
@shlomi-noach shlomi-noach deleted the backport_6944 branch November 1, 2020 09:58
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askdba askdba askdba approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rohit-nayak-ps @askdba