orc tests: add more cases #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <[email protected]>
shlomi-noach
approved these changes
Sep 30, 2020
| err := curMaster.MysqlctlProcess.Stop() | ||
| require.NoError(t, err) | ||
|
|
||
| for _, tablet := range shard0.Vttablets { |
There was a problem hiding this comment.
where's the Sleep() now?
There was a problem hiding this comment.
It is inside the call to checkMasterTablet
| qr := runSQL(t, "select @@global.read_only", curMaster) | ||
| require.NotNil(t, qr) | ||
| require.Equal(t, 1, len(qr.Rows)) | ||
| require.Equal(t, "[[INT64(0)]]", fmt.Sprintf("%s", qr.Rows), qr.Rows) |
| require.NotNil(t, qr) | ||
| require.Equal(t, 1, len(qr.Rows)) | ||
| require.Equal(t, "[[INT64(1)]]", fmt.Sprintf("%s", qr.Rows), qr.Rows) | ||
| } |
| // wait for repair | ||
| time.Sleep(15 * time.Second) | ||
| // check replication is setup correctly | ||
| checkReplication(t, clusterInstance, curMaster, []*cluster.Vttablet{replica}) |
There was a problem hiding this comment.
I feel like these tests share a lot of code in common, the code should probably be refactored to provide a framework for setup-destroy-wait-expect cycle.
There was a problem hiding this comment.
I moved as much as possible into createCluster and checkReplication. What is left is slightly different in each test case.
As we add more tests we can revisit and refactor.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #6769
Signed-off-by: deepthi [email protected]