Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return database name #6757

Closed
wants to merge 1 commit into from

Conversation

hellobob
Copy link

The client got the wrong database name

5DD4ECD4-E695-488B-BDCD-5BEA5B99F5C0

21B4F287-4858-472A-A3CE-79EA095065D4

@hellobob hellobob requested a review from sougou as a code owner September 21, 2020 10:26
Signed-off-by: wangyunbo <[email protected]>
@harshit-gangal
Copy link
Member

harshit-gangal commented Sep 21, 2020

@hellobob I think there should be a better way to provide database name to sharding-jdbc. I have not looked into the details of this framework. But current approach looks hackish to me.

@sougou
Copy link
Contributor

sougou commented Sep 21, 2020

We need to find a longer and more stable solution for this problem. The vt_ is itself a default that can be changed using init_dbname_override. We should look at prioritizing the project to move this metadata into the shard record.

@systay
Copy link
Collaborator

systay commented Sep 22, 2020

Issue #6753

@deepthi
Copy link
Member

deepthi commented Oct 6, 2020

Superseded by #6791

@deepthi deepthi closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants