Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reparent tests which fail with tracker on #6711

Conversation

rohit-nayak-ps
Copy link
Contributor

Previously vreplication (and hence the schema tracker) was using dba privileges. This causes an issue during reparenting when the tracker continues to write to the schema_version table of the (readonly) replica due to the dba privileges causing errant gtids.

Signed-off-by: Rohit Nayak [email protected]

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
Signed-off-by: Rohit Nayak <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
…er on

Signed-off-by: Rohit Nayak <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
…sing the issue

Signed-off-by: Rohit Nayak <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
…hers with schema tracker on

Signed-off-by: Rohit Nayak <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
Signed-off-by: Rohit Nayak <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
rohit-nayak-ps Rohit Nayak
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps
Copy link
Contributor Author

@deepthi after skipping a couple of tests the test which used to fail earlier with the tracker on is working. The changing of dbuser to allprivs from dba doesn't really seem to matter though I have left it in since we want to do it anyway.

There seems to be some leakage from the two tests I skipped. If I enable TestMasterToSpareStateChangeImpossible then TestReparentNoChoiceDownMaster fails with the tracker on. If TestReparentGracefulRangeBased is enabled then TestReparentNoChoiceDownMaster fails earlier.

Is this dependence of tests on others by design?

@deepthi
Copy link
Member

deepthi commented Sep 14, 2020

@deepthi after skipping a couple of tests the test which used to fail earlier with the tracker on is working. The changing of dbuser to allprivs from dba doesn't really seem to matter though I have left it in since we want to do it anyway.

There seems to be some leakage from the two tests I skipped. If I enable TestMasterToSpareStateChangeImpossible then TestReparentNoChoiceDownMaster fails with the tracker on. If TestReparentGracefulRangeBased is enabled then TestReparentNoChoiceDownMaster fails earlier.

Is this dependence of tests on others by design?

Any dependency is not by design. Not sure why enabling one test fails the next one because each test cleans up the tablets when it is done. cluster teardown should bring down mysql as well.

@rohit-nayak-ps rohit-nayak-ps changed the title Change vreplication db user to allprivs Fix reparent tests which fail with tracker on Sep 14, 2020
@rohit-nayak-ps
Copy link
Contributor Author

Closed. Real fix is in #6726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants