Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker - allow BUILD_NUMBER variable override #6628

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

guidoiaquinti
Copy link
Member

@guidoiaquinti guidoiaquinti commented Aug 26, 2020

Description

Expose BUILD_NUMBER at Docker build time.

Why

We currently let to override BUILD_NUMBER at build time in a non-Docker environment, I think we should let to do the same in Docker. This will let user to build Vitess, via Docker, using something like:

docker build \
    --no-cache \
    --build-arg BUILD_NUMBER="$BUILD_NUMBER" \
    -t "${IMAGE_TAG}" \
    -f "${GIT_CHECKOUT}/docker/base/Dockerfile.${FLAVOR}" .

Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@derekperkins derekperkins merged commit 6a93dd1 into vitessio:master Sep 15, 2020
@guidoiaquinti guidoiaquinti deleted the docker_vars branch September 28, 2020 16:53
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants