tm: add more logging to checkMastership #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sugu Sougoumarane <[email protected]>
enisoc
approved these changes
Aug 25, 2020
| @@ -468,6 +469,7 @@ func (tm *TabletManager) checkMastership(ctx context.Context, si *topo.ShardInfo | |||
| }) | |||
| case err == nil: | |||
| if oldTablet.Type == topodatapb.TabletType_MASTER { | |||
| log.Infof("Shard master alias matches, and existing tablet agrees. Switching to master with tablet's master term start time: %v", oldTablet.MasterTermStartTime) | |||
There was a problem hiding this comment.
Maybe we should also log if oldTablet.Type was not MASTER? That means the shard record and tablet record disagree, which seems like an important case to call out.
There was a problem hiding this comment.
Hmm. In this case, would it be safe to make ourselves master and match the shard record's timestamp?
There was a problem hiding this comment.
I've added handling for a couple of more corner cases. LMK what you think.
Signed-off-by: Sugu Sougoumarane <[email protected]>
deepthi
approved these changes
Aug 25, 2020
enisoc
reviewed
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sugu Sougoumarane [email protected]