Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtcompose/docker-compose: fix InitShardMaster #6584

Merged
merged 1 commit into from
Aug 18, 2020
Merged

vtcompose/docker-compose: fix InitShardMaster #6584

merged 1 commit into from
Aug 18, 2020

Conversation

shlomi-noach
Copy link
Contributor

Fixes #6521

This PR removes deprecated InitTablet and introduces InitShardMaster. This is done by:

  • running one docker
  • per shard
  • after all shard tablets are initialized
  • that executes InitShardMaster on the *01 tablet (e.g. test-201)

@shlomi-noach shlomi-noach requested a review from sougou as a code owner August 18, 2020 08:32
@shlomi-noach shlomi-noach mentioned this pull request Aug 18, 2020
Closed
@shlomi-noach shlomi-noach requested a review from deepthi August 18, 2020 08:45
deepthi
deepthi approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you create another PR that cherry-picks this onto release-7.0?

@deepthi deepthi merged commit 2d0f294 into vitessio:master Aug 18, 2020
@deepthi deepthi added this to the 7.0.1 milestone Aug 18, 2020
@shlomi-noach shlomi-noach deleted the fix-docker-compose branch August 18, 2020 14:08
@shlomi-noach shlomi-noach mentioned this pull request Aug 18, 2020
Merged
@deepthi deepthi removed this from the 7.0.1 milestone Aug 18, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
@jawabuu jawabuu mentioned this pull request Nov 7, 2020
Merged
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.

docker-compose example is broken
3 participants
@shlomi-noach @deepthi @askdba