Allow SELECT options in any order #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go/vt/sqlparser/sql.y
Outdated
| { | ||
| $$ = []string{$1, $2} | ||
| } | ||
| | select_option select_option select_option //TODO I tried and got 'conflicts: 8 shift/reduce' |
harshit-gangal
approved these changes
Apr 20, 2020
| @@ -398,9 +400,10 @@ stream_statement: | |||
|
|
|||
| // base_select is an unparenthesized SELECT with no order by clause or beyond. | |||
| base_select: | |||
| SELECT comment_opt cache_opt distinct_opt straight_join_opt select_expression_list from_opt where_expression_opt group_by_opt having_opt | |||
| // 1 2 3 4 5 6 7 8 | |||
Makes it possible for options such as DISTINCT,SQL_CACHE and STRAIGHT_JOIN to be entered in any order. This is to follow MySQLs behaviour. Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
systay
force-pushed
the
at-select-options
branch
from
99b4789 to
c071043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible for options such as DISTINCT,SQL_CACHE and STRAIGHT_JOIN
to be entered in any order. This is to follow MySQLs behaviour.
Also adds one more new SELECT option -
sql_calc_found_rowsSigned-off-by: Andres Taylor [email protected]