messager: add special support for time_expires, min/maxBackoff #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Perkins <[email protected]>
This allows users to set reasonable bounds on message exponential backoff Signed-off-by: Derek Perkins <[email protected]>
derekperkins
force-pushed
the
time-expires
branch
from
99196af to
965b7f2
Compare
derekperkins
changed the title
|
Honestly I think that the expiration time should always be delivered with |
|
Closing this as this has diverged. You should be able to reimplement this in the new framework, and it should hopefully be much simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consumer of Vitess messages, it is currently impossible to know whether or not a message has expired or is about to expire. This PR provides a backwards compatible way for the actual message expiration time to be sent with the query results as a special cased pseudo field, configured with a table level comment.
While in the code, I also added the ability to set min and max backoff durations for exponential backoff. After enough attempts, message attempts can get pushed out for days, which is usually undesirable.
If this approach is acceptable, I'll go ahead and add tests.