Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmergencyReparentShard does not need to update shard master #5363

Merged
merged 1 commit into from
Oct 28, 2019
Merged

EmergencyReparentShard does not need to update shard master #5363

merged 1 commit into from
Oct 28, 2019

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Oct 27, 2019

Once the new master's type is changed, it will update the shard record.

Signed-off-by: deepthi [email protected]

@deepthi deepthi requested a review from sougou as a code owner October 27, 2019 02:39
@deepthi deepthi requested a review from enisoc October 27, 2019 02:39
@morgo morgo added this to the v4.0 milestone Oct 28, 2019
enisoc
enisoc approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enisoc enisoc merged commit 789a0e3 into vitessio:reparent-refactor Oct 28, 2019
@enisoc enisoc deleted the ds-ers branch October 28, 2019 23:49
@spark4 spark4 mentioned this pull request Nov 12, 2019
Closed
@spark4 spark4 mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc enisoc approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthi @enisoc @morgo