PlannedReparentShard: Allow retrying PRS to the existing master. #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisoc
force-pushed
the
retryable-planned-reparent-shard
branch
from
c7abdb0 to
ff59dfd
Compare
This is an incremental first step toward making PRS more useful for repairing situations when replication across a shard is not fully consistent. The main thing this enables is retrying the step of reconfiguring all replicas (including the old master) to point to the new master. Signed-off-by: Anthony Yeh <[email protected]>
Signed-off-by: Anthony Yeh <[email protected]>
enisoc
force-pushed
the
retryable-planned-reparent-shard
branch
from
63449eb to
d879a21
Compare
deepthi
approved these changes
Sep 26, 2019
go/vt/wrangler/reparent.go
Outdated
| wr.logger.Infof("updating shard record with new master %v", masterElectTabletAlias) | ||
| if _, err := wr.ts.UpdateShardFields(ctx, keyspace, shard, func(si *topo.ShardInfo) error { | ||
| si.MasterAlias = masterElectTabletAlias | ||
| return nil | ||
| }); err != nil { | ||
| wgSlaves.Wait() | ||
| wgReplicas.Wait() | ||
| return fmt.Errorf("failed to update shard master record: %v", err) | ||
| } | ||
|
|
||
| // Wait for the slaves to complete. |
Signed-off-by: Anthony Yeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental first step toward making PRS more useful for repairing situations when replication across a shard is not fully consistent.
The main thing this enables is retrying the step of reconfiguring all replicas (including the old master) to point to the new master.
Signed-off-by: Anthony Yeh [email protected]