Code

Point in time recovery (part 1)#5160

Code

Merged

deepthi merged 25 commits intovitessio:mastervitessio/vitess:masterfrom planetscale:ds-pitr2planetscale/vitess:ds-pitr2Copy head branch name to clipboardOct 7, 2019

+2,296-605

Commits

Commits on Oct 3, 2019

• CreateKeyspace for snapshot keyspaces

  Show description for 2e77b98
  deepthi

  committed
  2e77b98

  Copy full SHA for 2e77b98

• unit test for CreateKeyspace, fix CI test failures

  Show description for d56dff7
  deepthi

  committed
  d56dff7

  Copy full SHA for d56dff7

• add base_keyspace param to CreateKeyspace

  Show description for 1732232
  deepthi

  committed
  1732232

  Copy full SHA for 1732232

• fix test failures

  Show description for 4f2b45b
  deepthi

  committed
  4f2b45b

  Copy full SHA for 4f2b45b

• test PITR data access through vtgate

  Show description for d5a4202
  deepthi

  committed
  d5a4202

  Copy full SHA for d5a4202

• fix time formats and help text

  Show description for e3caf77
  deepthi

  committed
  e3caf77

  Copy full SHA for e3caf77

• add fields to Tablet record to store which backup we restored from, and which gtid we restored to

  Show description for d689461
  deepthi

  committed
  d689461

  Copy full SHA for d689461

• add multi-recovery integration test

  Show description for 3f8ad0d
  deepthi

  committed
  3f8ad0d

  Copy full SHA for 3f8ad0d

• simplify recovery test setup

  Show description for 404f898
  deepthi

  committed
  404f898

  Copy full SHA for 404f898

• sharded recovery testcase

  Show description for 513fd00
  deepthi

  committed
  513fd00

  Copy full SHA for 513fd00

• use vtctl SplitClone instead of vtworker

  Show description for 89d92f1
  deepthi

  committed
  89d92f1

  Copy full SHA for 89d92f1

• address review comments: use time.Time{} instead of time.Unix(0,0)

  Show description for 63ce15e
  deepthi

  committed
  63ce15e

  Copy full SHA for 63ce15e

• set initDbNameOverride on recovery tablets only if it is not already set

  Show description for eef29d1
  deepthi

  committed
  eef29d1

  Copy full SHA for eef29d1

• Improve testcases

  Show description for 97bde32
  deepthi

  committed
  97bde32

  Copy full SHA for 97bde32

• test recovery works even if old shard has already been deleted, test for recovered data per shard

  Show description for dc5f095
  deepthi

  committed
  dc5f095

  Copy full SHA for dc5f095

• improve error handling and comments

  Show description for defbcfc
  deepthi

  committed
  defbcfc

  Copy full SHA for defbcfc

• cleanup params handling, push dir/name computation into mysqlctl.Backup, fix bug in FindBackup for snapshot, misc review changes

  Show description for f64eeca
  deepthi

  committed
  f64eeca

  Copy full SHA for f64eeca

• save restore time and position in local_metadata instead of tablet record, more params cleanup and refactoring from reviews

  Show description for 060f148
  deepthi

  committed
  060f148

  Copy full SHA for 060f148

Commits on Oct 4, 2019

• add PITR test for xtrabackup

  Show description for ca6fffe
  deepthi

  committed
  ca6fffe

  Copy full SHA for ca6fffe

• unit tests for vtctl CreateKeyspace

  Show description for 1cc823c
  deepthi

  committed
  1cc823c

  Copy full SHA for 1cc823c

• fix unit test

  Show description for a9e5ffe
  deepthi

  committed
  a9e5ffe

  Copy full SHA for a9e5ffe

• Look for a backup created at or before specified time

  Show description for cbbb699
  deepthi

  committed
  cbbb699

  Copy full SHA for cbbb699

Commits on Oct 6, 2019

• Replace keyspace_type in vschema with a boolean require_explicit_routing

  Show description for ac3efb4
  deepthi

  committed
  ac3efb4

  Copy full SHA for ac3efb4

Commits on Oct 7, 2019

• DRY: centralize computation of backupDir

  Show description for ba6a23d
  deepthi

  committed
  ba6a23d

  Copy full SHA for ba6a23d

• do not override flags, more checks and logging

  Show description for 5df0107
  deepthi

  committed
  5df0107

  Copy full SHA for 5df0107