Execute "ALTER VSCHEMA" statements without specifying keyspace in the… #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalfonso
force-pushed
the
kalfonso.190828-later-vschema-keyspace
branch
2 times, most recently
from
072b2af to
b49782b
Compare
sougou
reviewed
Aug 29, 2019
go/vt/vtgate/executor_test.go
Outdated
| @@ -25,6 +25,7 @@ import ( | |||
| "net/http/httptest" | |||
| "reflect" | |||
| "sort" | |||
| "square/up/statsdaemon/assert" | |||
kalfonso
force-pushed
the
kalfonso.190828-later-vschema-keyspace
branch
from
b49782b to
ac091cd
Compare
… target connection. If the keyspace is not present in the target string, it will be derived in this case from the vindex and table qualifiers in the vschema sql statements Signed-off-by: Karel Alfonso Sague <[email protected]>
kalfonso
force-pushed
the
kalfonso.190828-later-vschema-keyspace
branch
from
ac091cd to
fc1ad42
Compare
sougou
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute "ALTER VSCHEMA" statements without specifying keyspace in the target connection.
If the keyspace is not present in the target string, it will be derived in this case from the vindex and table qualifiers in the vschema sql statements. This is already done by
func (e *Executor) handleVSchemaDDL(...)This PR enhanced "ALTER VSCHEMA CREATE VINDEX" and "ALTER VSCHEMA DROP VINDEX" to qualify the vindex name with the keyspace and provide this information to the AST.