Only override session.TargetString if it has not been set #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
approved these changes
Aug 26, 2019
gak
approved these changes
Aug 26, 2019
tirsen
force-pushed
the
jontirsen/2019-08-26/fix-use-for-mysql-with-dbname
branch
3 times, most recently
from
167334b to
70360eb
Compare
systay
approved these changes
Aug 26, 2019
demmer
requested changes
Aug 26, 2019
tirsen
force-pushed
the
jontirsen/2019-08-26/fix-use-for-mysql-with-dbname
branch
2 times, most recently
from
950b778 to
095dbd9
Compare
Signed-off-by: Jon Tirsen <[email protected]>
tirsen
force-pushed
the
jontirsen/2019-08-26/fix-use-for-mysql-with-dbname
branch
from
095dbd9 to
ad420aa
Compare
Signed-off-by: Jon Tirsen <[email protected]>
demmer
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Too bad the sandbox doesn't make it easier to properly test the keyspace-specific routing, but I agree with you this does most of what you wanted to test for the use statement.
For completeness you could test that the DbName can be overridden if invalid and cover the various other cases (prepare, etc). But I think this change is safe and straightforward enough that I wouldn't insist on the additional tests.
|
Yeah I agree. I spent a few hours digging into the sandbox and it doesn't look straightforward and certainly not worth the effort for this particular change. It would be nice with a more useful sandbox though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5132
Signed-off-by: Jon Tirsen [email protected]