vindexes.BuildVSchema: prevent one bad sequence from breaking all oth… #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweitzman
force-pushed
the
isolate_bad_seq_impact
branch
2 times, most recently
from
72ee957 to
197da89
Compare
…er sequences PR vitessio#4371 made vtgate more permissive about allowing bad data in a vschema without failing requests that only involve properly-configured tables. This PR extends that so a single table entry in the vschema that references a bad sequence won't disable the sequences for all the other tables with valid sequence configs. Signed-off-by: David Weitzman <[email protected]>
dweitzman
force-pushed
the
isolate_bad_seq_impact
branch
from
197da89 to
4937f39
Compare
mingjianliu
pushed a commit
to mingjianliu/vitess
that referenced
this pull request
Jul 16, 2020
Summary: 1) Don't let one bad sequence disable sequences for other tables vitessio#4743 2) Route "show create table" correctly vitessio#4732 Reviewers: #vitess, hzhou, mingjianliu Reviewed By: #vitess, mingjianliu Subscribers: mingjianliu, jenkins Differential Revision: https://phabricator.pinadmin.com/D382885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er sequences
PR #4371 made vtgate more permissive about allowing bad data in a vschema
without failing requests that only involve properly-defined tables.
This PR extends that so a single table entry in the vschema that references a bad
sequence won't disable the sequences for all the other tables with valid sequence
configs.