servenv: add new keepalive flag to grpc server #4737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a single grpc configuration flag for keepalive enforcement policy: PermitWithoutStream:. It defaults to false, the same as previous behavior. The purpose is to prevent potential zombie connections from vtgate to vttablet on intermittently active streams. We're already setting this to be true by default on the client side here:
vitess/go/vt/grpcclient/client.go
Lines 68 to 75 in 2af0d63
That setting doesn't take effect if it isn't also enabled server side.