Use jsonpb marshaling for vtctl's GetVSchema #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobufs should generally go through jsonpb to convert to and from json. One specific thing that's different with jsonpb's encoding is that "columnListAuthoritative" is camelCase vs json's encoding using snake_case. jsonpb is lenient about parsing json, accepting either snake or camel case. Signed-off-by: David Weitzman <[email protected]>
sougou
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobufs should generally go through jsonpb to convert to and from json.
One specific thing that's different with jsonpb's encoding is that
"columnListAuthoritative" is camelCase vs json's encoding using snake_case.
jsonpb is lenient about parsing json, accepting either snake or camel case.
There's a risk that custom scripts based on the old behavior of GetVSchema might break if they only support snake case and parse the output. jsonpb's
Unmarshal()should accept either snake or camel case.Signed-off-by: David Weitzman [email protected]