We should always time out health connections to a vttablet. #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpawliszyn
force-pushed
the
mikepaw.not-serving-infinite-loop
branch
2 times, most recently
from
2c20687 to
281c63c
Compare
Otherwise when a connection goes dead and the vttablet procees restarts the vtgate will never try to reestablish the connection. Signed-off-by: Michael Pawliszyn <[email protected]>
mpawliszyn
force-pushed
the
mikepaw.not-serving-infinite-loop
branch
from
281c63c to
ec6a753
Compare
systay
approved these changes
Feb 27, 2019
|
There is an exponential backoff when trying to reconnect to the tablet so I'm pretty sure we should time out in all cases. Even on non-serving. Otherwise dead TCP connections where the vtgate is waiting for a response will never get challenged. |
sougou
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when a connection goes dead and the vttablet procees restarts
the vtgate will never try to reestablish the connection.
Signed-off-by: Michael Pawliszyn [email protected]