-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staticcheck #4644
staticcheck #4644
Conversation
I haven't read through the whole diff. In general I would advocate for spitting up these kinds of changes into more, smaller, easier-to-review diffs unless the entire change has been written programmatically. |
Apologies for the huge diff. I didn't know when I started this how big it was going to be. The idea was to commit all the fixes along with the git hook so that things stay relatively clean after that. I have tried to keep each package in a separate commit to make it easier to review. |
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
Fix #4639
Replace
unused
git pre-commit hook withstaticcheck
Fix most of the errors thrown by staticcheck, ignore a few.