Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticcheck #4644

Merged
merged 33 commits into from
Mar 12, 2019
Merged

staticcheck #4644

merged 33 commits into from
Mar 12, 2019

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Feb 20, 2019

Fix #4639
Replace unused git pre-commit hook with staticcheck
Fix most of the errors thrown by staticcheck, ignore a few.

go/vt/mysqlctl/schema.go Outdated Show resolved Hide resolved
go/vt/vtctl/query.go Outdated Show resolved Hide resolved
@dweitzman
Copy link
Member

I haven't read through the whole diff. In general I would advocate for spitting up these kinds of changes into more, smaller, easier-to-review diffs unless the entire change has been written programmatically.

@deepthi
Copy link
Member Author

deepthi commented Mar 4, 2019

I haven't read through the whole diff. In general I would advocate for spitting up these kinds of changes into more, smaller, easier-to-review diffs unless the entire change has been written programmatically.

Apologies for the huge diff. I didn't know when I started this how big it was going to be. The idea was to commit all the fixes along with the git hook so that things stay relatively clean after that. I have tried to keep each package in a separate commit to make it easier to review.

deepthi added 18 commits March 7, 2019 11:12
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
@deepthi deepthi marked this pull request as ready for review March 7, 2019 21:12
@deepthi deepthi requested a review from sougou as a code owner March 7, 2019 21:12
Signed-off-by: deepthi <[email protected]>
@sougou sougou merged commit 4efa9c1 into vitessio:master Mar 12, 2019
@sougou sougou mentioned this pull request Mar 12, 2019
@harshit-gangal harshit-gangal deleted the ds-staticcheck branch July 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants