Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a reset of the slave on blank restore #4552

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

dkhenry
Copy link
Contributor

@dkhenry dkhenry commented Jan 25, 2019

In the event we are restoring from a backup, but there is no backup we need to reset master to accomidate flavors that write to the binlog on startup ( I'm looking at you MariaDB )

Signed-off-by: Dan Kozlowski [email protected]

In the event we are restoring from a backup, but there is no backup we need to reset master to accomidate flavors that write to the binlog on startup ( I'm looking at you MariaDB )

Signed-off-by: Dan Kozlowski <[email protected]>
@dkhenry dkhenry requested a review from sougou as a code owner January 25, 2019 06:15
Copy link
Contributor

@jvaidya jvaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sougou sougou merged commit 9f05436 into vitessio:master Jan 26, 2019
@harshit-gangal harshit-gangal deleted the dk-force-slave-reset-on-restore branch July 17, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants