Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tables that have columns named desc #4513

Merged

Conversation

rafael
Copy link
Member

@rafael rafael commented Jan 10, 2019

Desc

  • Tables with columns name 'desc' are not being parsed correctly. This adds a fix similar to the one in here:Fixes regression in parser #4172 to support such tables.

@rafael rafael requested a review from sougou as a code owner January 10, 2019 01:38
@sougou sougou merged commit c9a7e8c into vitessio:master Jan 12, 2019
@rafael rafael deleted the add-support-for-columns-named-desc branch January 15, 2019 05:45
@slanning
Copy link
Contributor

This seems to cause conflicts:

...
$ goyacc -o go/vt/sqlparser/sql.{go,y}

conflicts: 235 reduce/reduce
$ git checkout go/vt/sqlparser/sql.go
$ git bisect bad
698aa3721d6d23c824f6835969f811384ba6d04f is the first bad commit
...

@rafael
Copy link
Member Author

rafael commented Jan 15, 2019

@sougou - Do you know what might be happening here? I do not recall seeing that error when generating sql.go, but also seeing it if I try to recompile the parser.

@rafael rafael restored the add-support-for-columns-named-desc branch January 15, 2019 15:58
@rafael rafael deleted the add-support-for-columns-named-desc branch January 30, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants