build: fix broken build for other flavors #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few regressions that got introduced due to recent changes: * MYSQL_FLAVOR got dropped from Dockerfile.mariadb. * New build.env did not get included in the docker builds. * CapabilityClientDeprecateEOF behaves differently for MySQL 5.7 vs older versions: MySQL 5.6 and MariaDB. For 5.7, the capability always comes back true, but it comes back as true or false for other versions. So, I just removed the check. Also removed column length check in one of the tests because they are not consistent across flavors. Signed-off-by: Sugu Sougoumarane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few regressions that got introduced due to
recent changes:
vs older versions: MySQL 5.6 and MariaDB. For 5.7, the capability
always comes back true, but it comes back as true or false
for other versions. So, I just removed the check.
Also removed column length check in one of the tests because
they are not consistent across flavors.
Signed-off-by: Sugu Sougoumarane [email protected]