Refactor Delete plan to be consistent with update #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update plan was changed to support aliases. Even though we don't need aliases here, this refactor makes sure that the table is set in the same way as is done in that context. This makes both plans consistent and avoid potential confusion on why they differ. Signed-off-by: Rafael Chacon <[email protected]>
sougou
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update plan was changed to support aliases. Even though we don't need aliases
here, this refactor makes sure that the table is set in the same way as is done
in that context. This makes both plans consistent and avoid potential
confusion on why they differ.