Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for USING <identifier> to CREATE TABLE #3633

Merged
merged 1 commit into from
Feb 7, 2018
Merged

add support for USING <identifier> to CREATE TABLE #3633

merged 1 commit into from
Feb 7, 2018

Conversation

demmer
Copy link
Member

@demmer demmer commented Feb 6, 2018

We noticed that CREATE TABLE isn't parsing an index definition that includes USING BTREE.

Addressed with a simple change to the grammar leveraging an already existing rule that is part of CREATE INDEX.

@demmer demmer requested a review from sougou February 6, 2018 20:22
@sougou
Copy link
Contributor

sougou commented Feb 7, 2018 •
edited by alainjobart
Loading

LGTM

Approved with PullApprove

@alainjobart alainjobart merged commit 3f258c5 into vitessio:master Feb 7, 2018
@rafael rafael deleted the create-table-support-index-using-opt branch February 7, 2018 16:29
@rafael rafael mentioned this pull request Feb 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demmer @sougou @alainjobart @googlebot