helm: graceful MySQL termination + PodDisruptionBudgets #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisoc
reviewed
Jan 30, 2018
helm/vitess/templates/_vtgate.tpl
Outdated
| @@ -122,6 +122,22 @@ spec: | |||
| - name: creds | |||
| emptyDir: {} | |||
|
|
|||
| --- | |||
| ################################### | |||
| # vttablet PodDisruptionBudget | |||
There was a problem hiding this comment.
forgot to update comment to vtgate
helm/vitess/templates/_vttablet.tpl
Outdated
| apiVersion: policy/v1beta1 | ||
| kind: PodDisruptionBudget | ||
| metadata: | ||
| name: {{ $setName }} |
There was a problem hiding this comment.
It's a bit overly defensive for an object name, but by convention we try to use | quote for all strings.
derekperkins
force-pushed
the
termination-grace-period
branch
from
03891ac to
cb242c1
Compare
|
Thanks for the review. Nits now annihilated. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
terminationGracePeriodSecondsto 600 forvttabletto give MySQL more time than the default 30s to gracefully shut down.It also adds Pod Disruption Budgets to
vtgateandvttabletto only allow one pod per cell, keyspace, shard and tablet type to be unavailable at any point. This eliminates the possibility of voluntary actions taking down an entire shard.@enisoc