helm: add support for PMM #3598
Conversation
|
Also of note, I'm ignoring client errors until https://jira.percona.com/projects/PMM/issues/PMM-1985 is resolved. The client works, and worst case scenario where we ignore an error, it won't have any impact on actual Vitess/MySQL operations. @enisoc This is ready for review |
| # Copy CA certs for https calls | ||
| COPY --from=base /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt | ||
|
|
||
| RUN apt-get update && \ |
There was a problem hiding this comment.
We should put all these RUN commands into script file, and just COPY and RUN that. Currently since these are separate layers, we're still paying for the storage of all the removed files.
docker/k8s/pmm-client/Dockerfile
Outdated
| apt-get upgrade -qq && \ | ||
| apt-get install wget -qq --no-install-recommends | ||
|
|
||
| RUN wget https://www.percona.com/redir/downloads/pmm-client/1.6.1/binary/debian/stretch/x86_64/pmm-client_1.6.1-1.stretch_amd64.deb |
There was a problem hiding this comment.
Do they not have an apt repo we can add?
There was a problem hiding this comment.
They do. This seemed easier, but I can switch to their apt setup
helm/vitess/templates/_pmm.tpl
Outdated
| # --force is used because the pod ip address may have changed | ||
| pmm-admin config --server pmm.{{ $namespace }} --force | ||
|
|
||
| # each of these creates a systemd service |
There was a problem hiding this comment.
It seems weird to install a systemd service in a container. Can we not just run the server directly?
There was a problem hiding this comment.
Their whole setup is very opinionated and there isn't a way around this. You have to use their pmm-admin client and it doesn't have an option to run another way.
|
I batched all the |
This reduces the Docker image size from 72 MB to 45 MB
|
LGTM |
This adds optional support to auto-deploy PMM as a separate StatefulSet in Kubernetes, plus adds a
pmm-clientcontainer to vttablet, along with 2 log tailing containers, which auto-register with the server. It enables mysql metrics and query analytics by default.The PMM client requires root privileges in the container, so I was forced to remove
runAsNonRootfrom the default Pod Security Context, but all other containers are still running as a non-root user, so it shouldn't be an issue.