Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving optional RebuildKeyspace out of tests. #3268

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

alainjobart
Copy link
Contributor

vttablet's ActionAgent has three startup methods:

  1. real production tablet
  2. vtcombo in-memory tablet
  3. in-memory test tablet for unit tests
    The optional RebuildKeyspace when SrvKeyspace doesn't exist only needs
    to be done in case .1, not 2. and 3. vtcombo does an explicit rebuild
    after having fully created the keyspace (so we don't need the background
    intermediate ones that will fail and spam the logs anyway). in-memory
    tests don't ususally need the SrvKeyspace (and if they do, they could
    call it).

vttablet's ActionAgent has three startup methods:
1. real production tablet
2. vtcombo in-memory tablet
3. in-memory test tablet for unit tests
The optional RebuildKeyspace when SrvKeyspace doesn't exist only needs
to be done in case .1, not 2. and 3. vtcombo does an explicit rebuild
after having fully created the keyspace (so we don't need the background
intermediate ones that will fail and spam the logs anyway). in-memory
tests don't ususally need the SrvKeyspace (and if they do, they could
call it).
@michael-berlin
Copy link
Contributor

michael-berlin commented Oct 2, 2017

LGTM

Approved with PullApprove

@alainjobart alainjobart merged commit 4657600 into vitessio:master Oct 2, 2017
@alainjobart alainjobart deleted the vttablet branch October 2, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants