Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added query cache metrics #3245

Merged
merged 2 commits into from
Sep 30, 2017

Conversation

rafael
Copy link
Member

@rafael rafael commented Sep 25, 2017

Description

Exposed metrics for query cache.

Should we call this metric PlanCache* to make it consistent with the code?

I think it makes more sense to keep it like this (QueryCache*), so it's consistent with the one in tabletserver. But curious to read what people think about this.

Tests

  • Locally and dev cluster

@rafael rafael requested a review from sougou September 25, 2017 18:18
@demmer
Copy link
Member

demmer commented Sep 25, 2017

I'd say PlanCache makes more sense since vtgate (nor vttablet for that matter) isn't actually caching queries, it's caching query plans.

@derekperkins
Copy link
Member

Agreed. I did a double take when I first saw references to QueryCache, thinking that Vitess was supporting the deprecated MySQL QueryCache.

@bbeaudreault
Copy link
Contributor

+1 for PlanCache. Would be great to change any docs that refer to it as QueryCache as well. We've had some newcomers recently who have been confused by this.

@rafael
Copy link
Member Author

rafael commented Sep 25, 2017

Sounds good. Updated. I'll open a different PR to update tablet server and docs related to that one.

@sougou
Copy link
Contributor

sougou commented Sep 30, 2017

LGTM

Approved with PullApprove

@sougou sougou merged commit 740b01e into vitessio:master Sep 30, 2017
@ajm188 ajm188 deleted the add-stats-query-cache-vtgaate branch January 14, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants