two minor logging changes #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntifiers When tablet state changes, the logs currently include a verbose dump of the Tablet as well as the before and after Target objects. Use the existing TabletIdent and add an analogous TargetIdent helper function to print more concise versions of the same information.
The error message added in b5339b7 didn't include format string entries for all the arguments, so add them for a nicer warning message.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the logging in
HealthCheckUpdatemore concise by leveraging the previously addedTabletIdentstring representation and adding an analogous function for concisely identifying a shardTarget.Along the way I happened to notice that the warning log added in #3084 didn't reference all the arguments in the format string, so I reworked the string so all the arguments are properly included.