Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset shard targeting using USE with no argument #3058

Conversation

tirsen
Copy link
Collaborator

@tirsen tirsen commented Aug 14, 2017

No description provided.

@@ -843,7 +843,7 @@
"revisionTime": "2017-03-23T10:04:54Z"
},
{
"checksumSHA1": "KG+XZAbxdkpBm3Fa3bJ3Ylq8CKI=",
"checksumSHA1": "MRLtTu/vpd18le8/HPLxOdjO5RE=",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the vendor changes?

@tirsen
Copy link
Collaborator Author

tirsen commented Aug 22, 2017

@sougou So it seems we have to deal with the goyacc version upgrade after all. The error messages have changed entirely between the version I am able to install and the version that you have.

@tirsen tirsen force-pushed the jontirsen/2017-08-14/use-reset-shard-targetting branch 2 times, most recently from 076c39b to 3dbd4af Compare August 28, 2017 12:47
@tirsen tirsen force-pushed the jontirsen/2017-08-14/use-reset-shard-targetting branch from 3dbd4af to 3766134 Compare September 1, 2017 12:28
@sougou
Copy link
Contributor

sougou commented Sep 3, 2017

LGTM

Approved with PullApprove

@sougou sougou merged commit fc4674f into vitessio:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants