Fix gitignore vi #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This contains both changes now? How come? Anyway, this single change LGTM |
demmer
added a commit
that referenced
this pull request
Apr 26, 2017
update to latest and truncate long queries in ui
sougou
pushed a commit
that referenced
this pull request
Jun 21, 2018
systay
pushed a commit
that referenced
this pull request
May 6, 2021
…ion/cancellation This is a combination of 4 commits. This is the commit message #2: Check that routing rules are deleted in unit test This is the commit message #3: Fix typo This is the commit message #4: Refresh all tablets in a shard when updating blacklisted tables Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Andres Taylor <[email protected]>
3 tasks
mattlord
added a commit
that referenced
this pull request
Jul 2, 2022
* Implement VDiff2 delete command Also add --verbose flag for VDiff output Signed-off-by: Matt Lord <[email protected]> * Delete vdiff metadata associated with a deleted workflow Signed-off-by: Matt Lord <[email protected]> * Tweaks after self review Signed-off-by: Matt Lord <[email protected]> * Self review #2 Signed-off-by: Matt Lord <[email protected]> * Spelling is herd Signed-off-by: Matt Lord <[email protected]> * Add test for vdiff data cleanup on workflow deletion Signed-off-by: Matt Lord <[email protected]> * Caught mistake on self-review #3 Signed-off-by: Matt Lord <[email protected]> * Add a couple more delete tests Signed-off-by: Matt Lord <[email protected]> * Clear out vdiff_log table as well on workflow deletion Signed-off-by: Matt Lord <[email protected]>
maxenglander
added a commit
to maxenglander/vitess
that referenced
this pull request
Aug 23, 2022
…t, +sc.expiryTime Signed-off-by: Max Englander <[email protected]>
harshit-gangal
pushed a commit
that referenced
this pull request
Sep 7, 2022
* decouple olap tx timeout from oltp tx timeout Since workload=olap bypasses the query timeouts (--queryserver-config-query-timeout) and also row limits, the natural assumption is that it also bypasses the transaction timeout. This is not the case, e.g. for a tablet where the --queryserver-config-transaction-timeout is 10. This commit: * Adds new CLI flag and YAML field to independently configure TX timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout). * Decouples TX kill interval from OLTP TX timeout via new CLI flag and YAML field (--queryserver-config-transaction-killer-interval). Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #1 Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: remove unused tx killer flag Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests Signed-off-by: Max Englander <[email protected]> * revert fmt changes Signed-off-by: Max Englander <[email protected]> * implement pr review suggestion Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>
maxenglander
added a commit
to maxenglander/vitess
that referenced
this pull request
Oct 4, 2022
* decouple olap tx timeout from oltp tx timeout Since workload=olap bypasses the query timeouts (--queryserver-config-query-timeout) and also row limits, the natural assumption is that it also bypasses the transaction timeout. This is not the case, e.g. for a tablet where the --queryserver-config-transaction-timeout is 10. This commit: * Adds new CLI flag and YAML field to independently configure TX timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout). * Decouples TX kill interval from OLTP TX timeout via new CLI flag and YAML field (--queryserver-config-transaction-killer-interval). Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#1 Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#2 consolidate timeout logic in sc Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: remove unused tx killer flag Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#3 -txProps.timeout, +sc.expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#4 -atomic.Value for expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#5 -unused funcs, fix comments, set ticks interval once Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments vitessio#5 +txkill tests Signed-off-by: Max Englander <[email protected]> * fix flags Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>
adsr
pushed a commit
to adsr/vitess
that referenced
this pull request
Feb 23, 2023
…dpoint (vitessio#3) `/debug/liveness` endpoint now returns a 503 when `/etc/etsy/depool` is present on the filesystem note: included "unit" test currently relies on `/etc/etsy` existing and being writable. run with `go test go/vt/servenv/*.go` Signed-off-by: Mackenzie Starr <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.