Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uint64 for binary log file position #17472

Merged
merged 15 commits into from
Jan 10, 2025

Use const literal for byte index

cc53c8c
Select commit
Loading
Failed to load commit list.
Merged

Use uint64 for binary log file position #17472

Use const literal for byte index
cc53c8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 1s

67.67% (+0.01%) compared to 69e0224

View this Pull Request on Codecov

67.67% (+0.01%) compared to 69e0224

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (69e0224) to head (cc53c8c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
go/mysql/binlog_event_common.go 0.00% 3 Missing ⚠️
go/vt/vtorc/inst/binlog.go 33.33% 2 Missing ⚠️
go/mysql/binlog_event_filepos.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17472      +/-   ##
==========================================
+ Coverage   67.66%   67.67%   +0.01%     
==========================================
  Files        1584     1584              
  Lines      254394   254472      +78     
==========================================
+ Hits       172139   172220      +81     
+ Misses      82255    82252       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.