Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Compatibility Around LAST_INSERT_ID - evalengine #17409

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

systay
Copy link
Collaborator

@systay systay commented Dec 19, 2024

Description

This PR improves LAST_INSERT_ID(x) behavior to align more closely with MySQL in various scenarios.

  • EvalEngine Enhancement: We now handle LAST_INSERT_ID(x) queries directly in vtgate, allowing “dual-only” queries without sending them downstream to MySQL.
select last_insert_id(123);
  • VTGate-Calculated Values: Queries like:
SELECT last_insert_id(count(*)) FROM user WHERE foo = 'bar';

can be processed at vtgate level (aggregation across shards), rather than relying on MySQL for the final result.

Limitation

  • MySQL sets the session’s LAST_INSERT_ID value to the last row returned in ordered queries such as:
SELECT last_insert_id(col) FROM table ORDER BY foo;

In Vitess, we do not guarantee that the last row dictates the session value. The session’s LAST_INSERT_ID might be derived from a different row.


This PR contains commits from #17408

When merging this, please also merge the docs PR: vitessio/website#1913

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Dec 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 19, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 19, 2024
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 19, 2024
@systay systay force-pushed the last-insert-id-step2 branch from 6fcd9e1 to b6295b7 Compare December 19, 2024 06:24
@systay systay force-pushed the last-insert-id-step2 branch 2 times, most recently from c7364f5 to e133d2f Compare December 19, 2024 07:29
@systay systay marked this pull request as draft December 20, 2024 06:59
@systay systay force-pushed the last-insert-id-step2 branch from c270b66 to a18dc21 Compare December 20, 2024 12:37
@systay systay marked this pull request as ready for review December 20, 2024 12:37
@harshit-gangal
Copy link
Member

This PR should handle all the insert cases for last_insert_id

@systay systay force-pushed the last-insert-id-step2 branch 3 times, most recently from c696235 to 8880146 Compare January 7, 2025 14:47
@frouioui frouioui force-pushed the last-insert-id-step2 branch from 8880146 to d495b01 Compare January 7, 2025 15:53
@frouioui frouioui mentioned this pull request Jan 7, 2025
5 tasks
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the last-insert-id-step2 branch from d495b01 to e6e6742 Compare January 7, 2025 16:16
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui marked this pull request as ready for review January 7, 2025 16:19
"main.unsharded"
]
},
"skip_e2e": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be skipped

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to be skipped. we keep getting primary key violations if we don't skip it

Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall,
Let's update website doc for compatibility and mention the limitations and new support added.

@harshit-gangal harshit-gangal added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) NeedsWebsiteDocsUpdate What it says labels Jan 8, 2025
@systay systay removed the NeedsWebsiteDocsUpdate What it says label Jan 8, 2025
@systay
Copy link
Collaborator Author

systay commented Jan 8, 2025

Added docs vitessio/website#1913

@systay systay added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) and removed release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) labels Jan 8, 2025
@systay systay removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Evalengine changes to the evaluation engine Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants