-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Compatibility Around LAST_INSERT_ID - evalengine #17409
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
6fcd9e1
to
b6295b7
Compare
c7364f5
to
e133d2f
Compare
c270b66
to
a18dc21
Compare
This PR should handle all the insert cases for |
c696235
to
8880146
Compare
8880146
to
d495b01
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
d495b01
to
e6e6742
Compare
Signed-off-by: Florent Poinsard <[email protected]>
"main.unsharded" | ||
] | ||
}, | ||
"skip_e2e": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be skipped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs to be skipped. we keep getting primary key violations if we don't skip it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall,
Let's update website doc for compatibility and mention the limitations and new support added.
Added docs vitessio/website#1913 |
Signed-off-by: Andres Taylor <[email protected]>
Description
This PR improves
LAST_INSERT_ID(x)
behavior to align more closely with MySQL in various scenarios.LAST_INSERT_ID(x)
queries directly in vtgate, allowing “dual-only” queries without sending them downstream to MySQL.can be processed at vtgate level (aggregation across shards), rather than relying on MySQL for the final result.
Limitation
In Vitess, we do not guarantee that the last row dictates the session value. The session’s
LAST_INSERT_ID
might be derived from a different row.This PR contains commits from #17408
When merging this, please also merge the docs PR: vitessio/website#1913
Related Issue(s)
Checklist