Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of vtorc topo calls #17071

Merged
merged 12 commits into from
Nov 6, 2024

fix type-typo

707ad06
Select commit
Loading
Failed to load commit list.
Merged

Improve efficiency of vtorc topo calls #17071

fix type-typo
707ad06
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2024 in 0s

67.41% (+0.23%) compared to fa5a2c5

View this Pull Request on Codecov

67.41% (+0.23%) compared to fa5a2c5

Details

Codecov Report

Attention: Patch coverage is 15.94203% with 58 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (fa5a2c5) to head (707ad06).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/topo/shard.go 0.00% 54 Missing ⚠️
go/vt/vtorc/logic/tablet_discovery.go 0.00% 3 Missing ⚠️
go/vt/topo/tablet.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17071      +/-   ##
==========================================
+ Coverage   67.17%   67.41%   +0.23%     
==========================================
  Files        1571     1569       -2     
  Lines      252246   252171      -75     
==========================================
+ Hits       169458   170002     +544     
+ Misses      82788    82169     -619     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.