Improve errant GTID detection in ERS to handle more cases. #16926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
GuptaManan100
added
Type: Enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16926 +/- ##
==========================================
- Coverage 67.16% 67.15% -0.01%
==========================================
Files 1571 1571
Lines 252093 252228 +135
==========================================
+ Hits 169314 169381 +67
- Misses 82779 82847 +68 ☔ View full report in Codecov by Sentry. |
5 tasks
…parentJournalInfo implemented Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
rohit-nayak-ps,
shlomi-noach,
notfelineit and
systay
as code owners
deepthi
reviewed
Oct 22, 2024
deepthi
reviewed
Oct 22, 2024
…rovement Signed-off-by: Manan Gupta <[email protected]>
…nted Signed-off-by: Manan Gupta <[email protected]>
…code Signed-off-by: Manan Gupta <[email protected]>
deepthi
approved these changes
Oct 24, 2024
Signed-off-by: Manan Gupta <[email protected]>
…nal info Signed-off-by: Manan Gupta <[email protected]>
|
This is the report from the coverage tests - The two that are important to note are - The only lines untested by the unit tests in Overall, we are going from 90.5% coverage to 91% coverage in this PR. |
shlomi-noach
approved these changes
Oct 27, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the code changes for reworking the errant GTID detection in ERS. As proposed in #16724 (comment), we now also use the reparent journal length as an extra data point for GTID detection. All the different cases listed in #16274 have been added as unit tests in this PR, and the expectations of the algorithm have been verified.
Since,
ReadReparentJournalInfois a new RPC, there can be customers that upgrade Vitess multiple versions at a time (we are adding the new RPC in v21, but it is not available in releases prior to that). In this case, the vttablets won't have the RPC implemented. Since we don't want ERS to stop working in this situation, we have to keep the legacy errant GTID code around for this scenario. So, if reading the reparent journal information fails on any tablet, then we revert to using that legacy errant GTID detection code.Related Issue(s)
Checklist
Deployment Notes