Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker_local from Makefile #16335

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Remove docker_local from Makefile #16335

merged 2 commits into from
Jul 8, 2024

Conversation

kirtanchandak
Copy link
Contributor

@kirtanchandak
remove docker_local
bdf1c60 
Signed-off-by: kirtanchandak <[email protected]>
@kirtanchandak kirtanchandak requested a review from deepthi as a code owner July 4, 2024 07:21
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 4, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 4, 2024
@frouioui frouioui added Type: Internal Cleanup Component: Build/CI Component: Examples and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 4, 2024
frouioui
frouioui approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, linked to vitessio/website#1781

Looks good to me! Happy first contribution to vitess!

@frouioui frouioui mentioned this pull request Jul 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (c70031d) to head (8297e8a).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16335   +/-   ##
=======================================
  Coverage   68.71%   68.71%           
=======================================
  Files        1547     1547           
  Lines      198274   198267    -7     
=======================================
- Hits       136251   136247    -4     
+ Misses      62023    62020    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frouioui
frouioui reviewed Jul 4, 2024
View reviewed changes
Makefile Outdated
@@ -331,9 +331,6 @@ docker_lite_all: docker_lite $(DOCKER_LITE_TARGETS)
docker_lite:
${call build_docker_image,docker/lite/Dockerfile,vitess/lite}

docker_local:
${call build_docker_image,docker/local/Dockerfile,vitess/local}

docker_run_local:
./docker/local/run.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove this please, we do not need it anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this = docker_run_local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this too!

@frouioui frouioui mentioned this pull request Jul 4, 2024
Merged
@kirtanchandak
remove docker_run_local
8297e8a 
Signed-off-by: kirtanchandak <[email protected]>
deepthi
deepthi approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged after vitessio/website#1781

@frouioui frouioui merged commit 5a3bef5 into vitessio:main Jul 8, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Component: Examples Type: Internal Cleanup
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kirtanchandak @deepthi @frouioui