-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vtctldclient
container image
#16318
Merged
frouioui
merged 4 commits into
vitessio:main
from
runewake2:swronski/vtctldclient-container
Jul 2, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9110ec9
Add vtctldclient container
runewake2 f9049e3
Merge branch 'vitessio:main' into swronski/vtctldclient-container
runewake2 fba947f
Add vtctldclient image to published images list
runewake2 2ed1e90
Update docker/binaries/vtctldclient/Dockerfile
runewake2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Copyright 2024 The Vitess Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
ARG VT_BASE_VER=latest | ||
ARG DEBIAN_VER=stable-slim | ||
|
||
FROM vitess/lite:${VT_BASE_VER} AS lite | ||
|
||
FROM debian:${DEBIAN_VER} | ||
|
||
RUN apt-get update && \ | ||
apt-get upgrade -qq && \ | ||
apt-get install jq curl -qq --no-install-recommends && \ | ||
apt-get autoremove && \ | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
COPY --from=lite /vt/bin/vtctldclient /usr/bin/ | ||
|
||
# add vitess user/group and add permissions | ||
RUN groupadd -r --gid 2000 vitess && \ | ||
useradd -r -g vitess --uid 1000 vitess | ||
|
||
CMD ["/usr/bin/vtctldclient"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming jq and curl are in here for debugging? I know they're in the other Dockerfiles, so I don't want to gate this change on it, but should we think about moving to distroless for most of these binaries? The only ones offhand I can think of that need Linux might be vttablet since it uses installs the mysql client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we should think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are mostly to align with the existing
vtctlclient
image. I can remove the entireRUN
layer since I don't think any of the apt-get functionality is required for this to work if that'd be preferred.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you are proposing right now is fine. IMHO moving to distroless should eventually be done to all images in a subsequent PR so we have something consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this PR is great as is to stay consistent with vtctlclient