-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/golang/protobuf
to v1.5.4
#15426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
requested review from
ajm188,
deepthi,
harshit-gangal,
mattlord,
rohit-nayak-ps and
systay
as code owners
March 8, 2024 20:33
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 8, 2024
frouioui
added
Backport to: release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Build/CI
Type: CI/Build
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 8, 2024
deepthi
approved these changes
Mar 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15426 +/- ##
==========================================
+ Coverage 65.72% 65.73% +0.01%
==========================================
Files 1562 1562
Lines 193952 193952
==========================================
+ Hits 127474 127496 +22
+ Misses 66478 66456 -22 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Mar 8, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Florent Poinsard <[email protected]>
vitess-bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Florent Poinsard <[email protected]>
May need to also backport this to release-17.0 because of #15408 |
Manually cherry-picked this into #15408 |
frouioui
pushed a commit
that referenced
this pull request
Mar 9, 2024
…#15428) Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui
pushed a commit
that referenced
this pull request
Mar 9, 2024
…#15427) Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Build/CI
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the
github.com/golang/protobuf
dependency fromv1.5.3
tov1.5.4
to fix an incompatibility with thegoogle.golang.org/[email protected]
package.Backporting this to
release-18.0
andrelease-19.0
as we usegoogle.golang.org/[email protected]
on both branches.Related Issue(s)
Checklist
Deployment Notes