Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planbuilder bugfix: expose columns through derived tables #14501

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 9, 2023

Description

Somehow we missed adding the relevant tests, and the issue resurfaced.

For this query:

SELECT c.column_name FROM user c JOIN (
    SELECT table_name FROM unsharded LIMIT 1) AS tables 
ON tables.table_name = c.table_name

The planner changes the sides, because we use a nested loop join, and it's much easier to have the limited side on the left - we don't even have the code to support LIMIT on the RHS of our joins.

Somehow, when planning the limited LHS of the join, we did not pull out the table_name column from the derived table, and instead returned a literal 1:

select 1 from (select table_name from unsharded limit 1) as `tables`

This value was then used on the RHS to search for matches, and most often there were none.

Related Issue(s)

Fixes #12649

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Nov 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 9, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 9, 2023
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 9, 2023
harshit-gangal

This comment was marked as resolved.

@harshit-gangal harshit-gangal merged commit 817c24e into vitessio:main Nov 10, 2023
115 checks passed
@harshit-gangal harshit-gangal deleted the derived-single-shard branch November 10, 2023 07:56
systay added a commit that referenced this pull request Nov 13, 2023
systay added a commit that referenced this pull request Nov 14, 2023
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gen4 planner does not always add the JoinVars columns to the LHS of a Join
3 participants