-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planbuilder bugfix: expose columns through derived tables #14501
Merged
harshit-gangal
merged 3 commits into
vitessio:main
from
planetscale:derived-single-shard
Nov 10, 2023
Merged
planbuilder bugfix: expose columns through derived tables #14501
harshit-gangal
merged 3 commits into
vitessio:main
from
planetscale:derived-single-shard
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
November 9, 2023 14:28
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 9, 2023
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 9, 2023
GuptaManan100
approved these changes
Nov 10, 2023
Signed-off-by: Andres Taylor <[email protected]>
harshit-gangal
approved these changes
Nov 10, 2023
This was referenced Nov 10, 2023
systay
added a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Andres Taylor <[email protected]>
systay
added a commit
that referenced
this pull request
Nov 14, 2023
…les (#14501) (#14504) Co-authored-by: Andrés Taylor <[email protected]>
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
…4501) Signed-off-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somehow we missed adding the relevant tests, and the issue resurfaced.
For this query:
The planner changes the sides, because we use a nested loop join, and it's much easier to have the limited side on the left - we don't even have the code to support LIMIT on the RHS of our joins.
Somehow, when planning the limited LHS of the join, we did not pull out the
table_name
column from the derived table, and instead returned a literal1
:This value was then used on the RHS to search for matches, and most often there were none.
Related Issue(s)
Fixes #12649
Checklist