datetime: obey the evalengine's environment time #14358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The evaluation environment in the
evalengine
sets a frozentime.Time
value upon creation, to ensure that all time-related APIs in the engine are evaluated consistently, following MySQL's behavior.However, there are APIs in the
datetime
package that calltime.Now()
directly, particularly when converting from a time value to a datetime value. This is not correct! These APIs must use the frozen time set in theevalengine
. This PR updates the APIs to take a time input when necessary.cc @dbussink
Related Issue(s)
Found when working on #14310, follow up to #14351
Checklist
Deployment Notes