Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-16.0] Don't run any reparent commands if the host is empty (#13396) #13402

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This is a backport of #13396

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 28, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v16.0.3 milestone Jun 28, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 28, 2023
@deepthi
Copy link
Member

deepthi commented Jun 28, 2023

Upgrade/Downgrade test is failing. I've seen this type of failure several times but I can't recall whether it is flakiness that goes away on re-run. It's worth at least examining the failure before re-trying.
EDIT: This actually ran 3 times and failed all 3 times.

@GuptaManan100
Copy link
Member Author

@deepthi This test has been failing on other release-16.0 backports too. I'll investigate it separately.

@GuptaManan100 GuptaManan100 merged commit 2d41d38 into vitessio:release-16.0 Jun 29, 2023
@GuptaManan100 GuptaManan100 deleted the empty-hostname-16 branch June 29, 2023 06:19
@GuptaManan100
Copy link
Member Author

Found the bug - #13407 and the fix - #13408

@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants